Handle GIF images with missing clear code#2884
Closed
Erik-White wants to merge 1 commit intoSixLabors:mainfrom
Closed
Handle GIF images with missing clear code#2884Erik-White wants to merge 1 commit intoSixLabors:mainfrom
Erik-White wants to merge 1 commit intoSixLabors:mainfrom
Conversation
|
|
Author
|
I saw now that this is a duplicate of #2880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Closes #2883
It looks like the LZW decoder is missing a bounds check so if no clear code is read it will result in a buffer overread.
I think this fix makes sense, but I don't know if the resulting output is what is expected. It's probably difficult to know what the output should be if the file is truncated or corrupt.