Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Simplexity-Development/SimpleBucketMobs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: Simplexity-Development/SimpleBucketMobs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: updating-texture-stuff
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 32 files changed
  • 2 contributors

Commits on Apr 3, 2025

  1. Configuration menu
    Copy the full SHA
    124b4d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2025

  1. Configuration menu
    Copy the full SHA
    f755645 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca603f7 View commit details
    Browse the repository at this point in the history
  3. Some cleanup

    RhythmicSys committed Jul 22, 2025
    Configuration menu
    Copy the full SHA
    536ed56 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0a70a69 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2025

  1. Move to maven

    - add support for variants
    RhythmicSys committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    ad9badc View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2025

  1. Refactored Config

    - Config should now be more dynamic
    - default rules for bucketing mobs
    - Moved style configs under 'bucket-style'
    - Adjusted handling to use new formats
    RhythmicSys committed Jul 31, 2025
    Configuration menu
    Copy the full SHA
    46ac9c6 View commit details
    Browse the repository at this point in the history
  2. Adjusted item model stuff

    - getItemModel now returns the actual key
    - validation of the string happens in the Texture class now
    - Started work on making capture items and captured items more customizable
    RhythmicSys committed Jul 31, 2025
    Configuration menu
    Copy the full SHA
    e5e105d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2026

  1. Fix config key mismatch, entity spawn location, and several event-han…

    …dling bugs
    
    ConfigHandler was reading from bucket-style.* keys that never existed in
    config.yml; the correct section is captured-item-style.*. This silently
    ignored every style setting (name, glint, material, item model, resource
    pack toggle) and fell back to Java-side defaults. Fixed all key paths.
    
    config.yml had item-model: default, which is not a valid NamespacedKey and
    logged a warning on every reload. Changed to minecraft:bucket.
    
    Entity release now uses NMS Entity.setPos() via reflection before
    addEntity() is called, so mobs spawn at the release location directly.
    The previous approach (teleport before/after addEntity) broke when the
    capture chunk was unloaded, because teleport() requires the entity to
    already be in a world, and addEntity() always used the stored NBT position.
    
    Additional fixes:
    - Enchantment glint config option was always hardcoded to true; now reads
      isEnchantmentGlint() from ConfigHandler
    - Dead-code loop in setupTypes() added disallowed types to entityRules then
      immediately cleared them; removed the loop
    - onBucketMob and onUnbucketMob now guard on EquipmentSlot.HAND to avoid
      processing off-hand duplicate events
    - Event is now cancelled before world mutations in onBucketMob so other
      listeners do not see a half-removed entity
    - Debucket command: added null check for empty main hand, and now handles
      both the legacy string tag and the new byte-array tag
    - Texture config load error now goes through the SLF4J logger instead of
      printStackTrace()
    Rhythmic authored and Rhythmic committed Apr 19, 2026
    Configuration menu
    Copy the full SHA
    ff50f2b View commit details
    Browse the repository at this point in the history
  2. update readme

    Rhythmic authored and Rhythmic committed Apr 19, 2026
    Configuration menu
    Copy the full SHA
    ec3359b View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2026

  1. Fix issues brought up in PR review, and swap out plugin.yml for paper…

    …-plugin.yml
    Rhythmic authored and Rhythmic committed Apr 21, 2026
    Configuration menu
    Copy the full SHA
    6fd149c View commit details
    Browse the repository at this point in the history
Loading