Skip to content

Conversation

@lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Sep 24, 2024

WHY are these changes introduced?

Allow the use of API versions that are not previously defined

WHAT is this pull request doing?

  • If the string passed in was not a previously defined release, make a new release on the fly

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@lizkenyon lizkenyon force-pushed the liz/make-api-version-more-flexible branch 5 times, most recently from d228d8e to 12bbe8b Compare September 24, 2024 19:03
Allow the use of API versions that are not previsouly defined
@lizkenyon lizkenyon force-pushed the liz/make-api-version-more-flexible branch from 12bbe8b to fdc155e Compare September 24, 2024 19:06
@sle-c sle-c self-requested a review September 24, 2024 20:48
Copy link
Contributor

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo still utilizes ActiveResource instead of generated resources like ruby so I think this approach works well

Copy link
Contributor

@matteodepalo matteodepalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyzhnenko
Copy link

Hey @paulomarg,

Please help with this PR.
When could it be merged?

TIA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants