Fix(725): Add support for building the package in Python 3.12 #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the [issue](Shopify#725) there is an issue when trying to install this package when using Python 3.12. The issue is caused by [PEP-632](https://peps.python.org/pep-0632/) removing `distutils` from the built-in libraries this version of python is shipped with. In versions 6.0.0 and lower of PyYaml, this causes the build the fail. As mentioned in their [issue](yaml/pyyaml#756) using v6.0.1 or later will resolve this issue. So updating our `setup.py` install_requires dependency specifications to reflect this. While I'm here, also update the classifiers to include support for PY3.12 and show this more clearly on the README of the repo.
Contributor
Author
|
I have signed the CLA! |
paulomarg
approved these changes
Jul 9, 2024
Contributor
paulomarg
left a comment
paulomarg
left a comment
There was a problem hiding this comment.
Thanks for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in the issue, there is an issue when installing this package using Python 3.12. The problem is caused by
PEP-632 removes
distutilsfrom the built-in libraries this version of Python is shipped with. In versions 6.0.0 and lower of PyYaml, this causes the build to fail. As mentioned in their issue, using v6.0.1 or later will resolve this issue. So, we are updating oursetup.pyinstall_requires dependency specifications to reflect this.While I'm here, I've also updated the classifiers to include support for PY3.12 and show this more clearly in the repo's README.
Checklist