Skip to content

Suggestion for supporting ongoing API version releases #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sinejoe wants to merge 2 commits into from
Closed

Suggestion for supporting ongoing API version releases #543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3a5069
Suggestion for allowing broader range of API versions factoring in ne…
sinejoe Oct 7, 2021
1c321f4
Fixes to precommit reported issues
sinejoe Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions shopify/api_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import re
from datetime import datetime


MIN_API_VERSION = "2019-04"


class InvalidVersionError(Exception):
Expand Down Expand Up @@ -27,12 +31,18 @@ def define_version(cls, version):
@classmethod
def define_known_versions(cls):
cls.define_version(Unstable())
cls.define_version(Release("2020-04"))
cls.define_version(Release("2020-07"))
cls.define_version(Release("2020-10"))
cls.define_version(Release("2021-01"))
cls.define_version(Release("2021-04"))
cls.define_version(Release("2021-07"))
# Generate quarterly API versions thru next release candidate
ver_yr = int(MIN_API_VERSION.split("-")[0])
ver_mo = int(MIN_API_VERSION.split("-")[1])
now = datetime.utcnow()
while ver_yr <= now.year + 1:
cls.define_version(Release("{0}-{1:02}".format(ver_yr, ver_mo)))
if ver_yr > now.year or ver_mo > now.month:
break
ver_mo += 3
if ver_mo > 12:
ver_yr += 1
ver_mo = 1

@classmethod
def clear_defined_versions(cls):
Expand Down