Suggestion for supporting ongoing API version releases #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w/ongoing quarterly releases and release candidates
ghost
added
the
mllemango
reviewed
Jan 4, 2022
Contributor
mllemango
left a comment
mllemango
left a comment
There was a problem hiding this comment.
I like this a lot
Would you mind adding unit tests?
Contributor
|
Hey @sinejoe, we're currently looking into alternative ways of automating these releases that would apply to all our libraries and it seems like we're leaning towards a more rigid control of api versions rather than what's being suggested here. Thanks for putting forth this change, it sparked a lot of conversation about how we want to proceed with these updates! With all that said, I'm going to close this PR, feel free to open it again if anything else comes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be less rigid with API versions. Having to manually update this repo every three months is getting cumbersome it seems and we are lagging behind by weeks in getting the new versions supported as they are released by Shopify. This repo doesn't need to strictly enforce the deprecations and new releases. Developers can still make a request to the 2019-04 api version successfully so there isn't a major need IMO to block deprecated API versions if a developer chooses to use. Further, each new release and the next release candidate should be usable/testable here without having to override.
WHY are these changes introduced?
Addresses original issue #339 for which a fix was attempted in #441 but caused more problems than solved.
WHAT is this pull request doing?
Replacing a fixed, hard-coded list of supported/valid API versions with an allowable range of all API versions plus new ones automatically going forward including next release candidate.
Checklist
I did not update these items awaiting acceptance or review/discussion of this PR.