[Feature] Add Dynamic api versioning #441
Merged
+24
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated fake() to reflect the use of a url
mllemango
approved these changes
Jan 4, 2021
Contributor
mllemango
left a comment
mllemango
left a comment
There was a problem hiding this comment.
Thank you for working on this! I've tested locally and this looks good!
Contributor
Author
|
Thanks! Happy to help. |
tanema
approved these changes
Jan 5, 2021
Contributor
|
(note that we're missing a changelog entry for this, even though the checkbox was checked). |
Contributor
|
Good catch, I'll add an entry with the new release PR if thats fine. |
mllemango
pushed a commit
that referenced
this pull request
Mar 25, 2021
Revert "Merge pull request #441 from smubbs/dynamic-api-version"
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will automatically populate with the current API versions supported for the Shopify Admin API.
Hopefully, this should remove the requirement to manually update the list of current API versions.
WHY are these changes introduced?
Fixes #339
Versioning has been here a while and it's probably time we fix this manual update requirement. A manual system is fine, but it still causes issues with development and to not be able to select the currently available APIs, that is to say, to have to wait for this package to be updated every quarter is unreasonable. It is now 25 November, Release Candidate 2021-01 has been available for also 2 months now and it is still not supported here.
WHAT is this pull request doing?
ApiVersion.define_known_versions()has been changed to make a request to https://app.shopify.com/services/apis.json and automatically populate the versions list.Updated
TestCase.fake()default to using anurlwhen provided or constructing one whenendpointis provided.Added payload
api_version.jsonfor call infake('apis'...)Checklist