Check for blank line after a class definition #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solackerman
approved these changes
Oct 13, 2017
JasonMWhite
reviewed
Oct 15, 2017
shopify_python/google_styleguide.py
Outdated
|
|
||
| def __class_def_check(self, node): # type: (astroid.ClassDef) -> None | ||
| """Enforce a blank line after a class definition line.""" | ||
| if isinstance(node, astroid.ClassDef): |
There was a problem hiding this comment.
Is this check necessary? Shouldn't visit_classdef only be called at a ClassDef line?
JasonMWhite
reviewed
Oct 15, 2017
shopify_python/google_styleguide.py
Outdated
| if isinstance(node, astroid.ClassDef): | ||
| class_def_line = node.lineno | ||
| for next_def in node.body: | ||
| if isinstance(next_def, astroid.FunctionDef): |
There was a problem hiding this comment.
If I'm reading this correctly, this would pass.
class SomeClass(object):
FOO = 1
def apply(self):
pass
I believe the rule might be better expressed as: there must be at least one blank line before the first method of a class. Thoughts?
JasonMWhite
approved these changes
Oct 16, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect missing blank line after a class definition. (moved from starscream specific linter as suggested in https://github.com/Shopify/starscream/pull/21070)