Problem

We're missing a few binary operators and there are a few situations when node.body.operand doesn't have a name during the check for whether we can use an operator function as opposed to a lambda function, e.g.:

Linting lambda key: not type_allowed(key._type) throws

if operator and not isinstance(node.body.operand, astroid.BinOp) and argname is node.body.operand.name:
17 AttributeError: 'Call' object has no attribute 'name'

Linting lambda key: not self.OUTPUT[key]["nullable"] throws

if operator and not isinstance(node.body.operand, astroid.BinOp) and argname is node.body.operand.name:
17 AttributeError: 'Subscript' object has no attribute 'name'

Linting lambda job: not job.is_loader throws

if operator and not isinstance(node.body.operand, astroid.BinOp) and argname is node.body.operand.name:
17 AttributeError: 'Attribute' object has no attribute 'name'

Solution

This PR:

• Adds some of the missing binary operators and reorders them to better match this list,
• Makes the operator check optional by calling get on the dictionary of them to prevent future exceptions from being thrown (resulting in potential false negatives for operators that aren't included, bugs can be reported to add them)
• Checks to ensure that the operand has a name before trying to use its name to prevent exceptions