Skip to content

Conversation

@angeml
Copy link

@angeml angeml commented Dec 6, 2021

Starscream has updated our default branch name to main and we need to be able to find it using the shopify_python git_utils tools used in our push hooks.

Should I actually be keeping master or is it ok to force an update to main for this version?

Copy link
Contributor

@cfournie cfournie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good for now, but maybe we could make the branch a parameter? That way the main branch is configurable and legacy projects can still use master temporarily.

@angeml
Copy link
Author

angeml commented Jan 24, 2022

We ended up going a different route for this and are no longer using shopify_python in starscream

@angeml angeml closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants