Include typing marker for mypy (PEP-561). #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlhamel
force-pushed
the
include-typing-marker-for-mypy
branch
from
1879773 to
5fc736d
Compare
mlhamel
commented
Nov 19, 2018
| @@ -1,4 +1,4 @@ | |||
| pycodestyle==2.3.1 | |||
| pycodestyle~=2.4 | |||
Contributor
Author
There was a problem hiding this comment.
I'm not sure I understand how it was working before cause it seems version 1.4.3 of autopep did depend of this (hhatto/autopep8@9583280#diff-2eeaed663bd0d25b7e608891384b7298)
Would it be better to stick to autopep8 <= 1.4.3 ?
Member
There was a problem hiding this comment.
Looks fine: I didn't see anything major going from 2.3 to 2.4.
It's impossible to be sure that no projects will tumble on that, but I think we should be going forward, not backward.
The minor version should be bumped.
cfournie
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
mypy, to better deal with typing from dependent packages we need to "advertise" our support of typing. As it it describe at https://www.python.org/dev/peps/pep-0561/#packaging-type-information, if you wantmypyto check for correct typing of dependant package and be able to ignore specific ones that don't support it, you need to add a specific marker in yoursetup.py.How does this PR work?
This PR is adding the typing marker to the setup.py