Filter unwanted product / variant attributes on creation #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Oct 5, 2020
lib/shopify_api/resources/product.rb
Outdated
| early_july_pagination_release! | ||
|
|
||
| def initialize(*args, **kwargs) | ||
| super(*args, **kwargs) |
Contributor
There was a problem hiding this comment.
This should be fine as just super.
Contributor
|
Since 2019-10 is no longer supported, would we be able to remove that check? |
paulomarg
force-pushed
the
fix_variant_serialization
branch
from
9678533 to
f6362d4
Compare
paulomarg
changed the title
Contributor
Author
Seems we may not be able to fully drop this code yet, as the Admin API still returns these fields and explicitly forbids saving them. So if we remove this code to filter out these fields, we'll end up trying to save them and that may lead to API requests failing. |
tanema
approved these changes
Oct 6, 2020
tanema
approved these changes
Oct 6, 2020
paulomarg
force-pushed
the
fix_variant_serialization
branch
from
f6362d4 to
f35d6c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775
Why am I making these changes?
We had reports that the changes made in #731 were causing the JSON serialization of API objects to break when
Base.api_versionwasn't set, for instance outside the scope of a temp session.The issue here was that we were filtering the fields out only when serializing the Product / Variant objects, rather than removing them altogether (even though they were no longer allowed in the API after version
2019-10).What is this PR doing?
This PR changes those objects so that we remove the fields when the object is first created, so that we don't need to check later on.