Allow cells to be unhighlighted - #172
Merged
Merged
Conversation
krbarnes
commented
Jun 24, 2019
raulriera
reviewed
Jun 25, 2019
raulriera
approved these changes
Jun 25, 2019
raulriera
left a comment
raulriera
left a comment
Contributor
There was a problem hiding this comment.
Tophat on the demo app is 🙆♂
krbarnes
force-pushed
the
unhighlight-cells
branch
2 times, most recently
from
June 25, 2019 20:23
d58bd71 to
5e5aa0e
Compare
krbarnes
force-pushed
the
unhighlight-cells
branch
from
June 25, 2019 20:50
5e5aa0e to
cfbc5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using CanSelectAction you should be able to cancel the selection and have the highlight cell revert to the previous one or none if nothing was selected. The code currently highlights the cell even if you cancel the selection.
This PR saves the original highlight cell and sets it to be highlighted again if the selection is cancelled.