More pylint corrections

tracyboehrer · tracyboehrer · commit a68c5e8d2ee4 · 2020-01-28T14:57:19.000-06:00
diff --git a/libraries/botbuilder-core/botbuilder/core/activity_handler.py b/libraries/botbuilder-core/botbuilder/core/activity_handler.py
@@ -23,8 +23,10 @@ async def on_turn(self, turn_context: TurnContext):
             In a derived class, override this method to add logic that applies to all activity types.
 
             .. note::
-                - Add logic to apply before the type-specific logic and before the call to the :meth:`ActivityHandler.on_turn()` method.
-                - Add logic to apply after the type-specific logic after the call to the :meth:`ActivityHandler.on_turn()` method.
+                - Add logic to apply before the type-specific logic and before the call to the
+                  :meth:`ActivityHandler.on_turn()` method.
+                - Add logic to apply after the type-specific logic after the call to the
+                  :meth:`ActivityHandler.on_turn()` method.
         """
         if turn_context is None:
             raise TypeError("ActivityHandler.on_turn(): turn_context cannot be None.")
@@ -72,15 +74,17 @@ async def on_message_activity(  # pylint: disable=unused-argument
 
     async def on_conversation_update_activity(self, turn_context: TurnContext):
         """
-        Invoked when a conversation update activity is received from the channel when the base behavior of :meth:`ActivityHandler.on_turn()` is used.
+        Invoked when a conversation update activity is received from the channel when the base behavior of
+        :meth:`ActivityHandler.on_turn()` is used.
 
         :param turn_context: The context object for this turn
         :type turn_context: :class:`TurnContext`
 
         :returns: A task that represents the work queued to execute
 
         .. note::
-            When the :meth:'ActivityHandler.on_turn()` method receives a conversation update activity, it calls this method.
+            When the :meth:'ActivityHandler.on_turn()` method receives a conversation update activity, it calls this
+            method.
             If the conversation update activity indicates that members other than the bot joined the conversation,
             it calls the  :meth:`ActivityHandler.on_members_added_activity()` method.
             If the conversation update activity indicates that members other than the bot left the conversation,
@@ -108,18 +112,20 @@ async def on_members_added_activity(
         self, members_added: List[ChannelAccount], turn_context: TurnContext
     ):  # pylint: disable=unused-argument
         """
-        Override this method in a derived class to provide logic for when members other than the bot join the conversation.
-        You can add your bot's welcome logic.
+        Override this method in a derived class to provide logic for when members other than the bot join
+        the conversation. You can add your bot's welcome logic.
 
-        :param members_added: A list of all the members added to the conversation, as described by the conversation update activity
+        :param members_added: A list of all the members added to the conversation, as described by the
+        conversation update activity
         :type members_added: :class:`typing.List`
         :param turn_context: The context object for this turn
         :type turn_context: :class:`TurnContext`
 
         :returns: A task that represents the work queued to execute
 
         .. note::
-            When the :meth:'ActivityHandler.on_conversation_update_activity()` method receives a conversation update activity that indicates
+            When the :meth:'ActivityHandler.on_conversation_update_activity()` method receives a conversation
+            update activity that indicates
             one or more users other than the bot are joining the conversation, it calls this method.
         """
         return
@@ -128,43 +134,50 @@ async def on_members_removed_activity(
         self, members_removed: List[ChannelAccount], turn_context: TurnContext
     ):  # pylint: disable=unused-argument
         """
-        Override this method in a derived class to provide logic for when members other than the bot leave the conversation.
-        You can add your bot's good-bye logic.
+        Override this method in a derived class to provide logic for when members other than the bot leave
+        the conversation.  You can add your bot's good-bye logic.
 
-        :param members_added: A list of all the members removed from the conversation, as described by the conversation update activity
+        :param members_added: A list of all the members removed from the conversation, as described by the
+        conversation update activity
         :type members_added: :class:`typing.List`
         :param turn_context: The context object for this turn
         :type turn_context: :class:`TurnContext`
 
         :returns: A task that represents the work queued to execute
 
         .. note::
-            When the :meth:'ActivityHandler.on_conversation_update_activity()` method receives a conversation update activity that indicates
-            one or more users other than the bot are leaving the conversation, it calls this method.
+            When the :meth:'ActivityHandler.on_conversation_update_activity()` method receives a conversation
+            update activity that indicates one or more users other than the bot are leaving the conversation,
+            it calls this method.
         """
 
         return
 
     async def on_message_reaction_activity(self, turn_context: TurnContext):
         """
-        Invoked when an event activity is received from the connector when the base behavior of :meth:'ActivityHandler.on_turn()` is used.
-
+        Invoked when an event activity is received from the connector when the base behavior of
+        :meth:'ActivityHandler.on_turn()` is used.
 
         :param turn_context: The context object for this turn
         :type turn_context: :class:`TurnContext`
 
         :returns: A task that represents the work queued to execute
 
         .. note::
-            Message reactions correspond to the user adding a 'like' or 'sad' etc. (often an emoji) to a previously sent activity.
-            Message reactions are only supported by a few channels. The activity that the message reaction corresponds to is indicated in the
-            reply to Id property. The value of this property is the activity id of a previously sent activity given back to the bot as the response
-            from a send call.
-            When the :meth:'ActivityHandler.on_turn()` method receives a message reaction activity, it calls this method.
-            If the message reaction indicates that reactions were added to a message, it calls :meth:'ActivityHandler.on_reaction_added().
-            If the message reaction indicates that reactions were removed from a message, it calls :meth:'ActivityHandler.on_reaction_removed().
+            Message reactions correspond to the user adding a 'like' or 'sad' etc. (often an emoji) to a previously
+            sent activity.
+            Message reactions are only supported by a few channels. The activity that the message reaction corresponds
+            to is indicated in the reply to Id property. The value of this property is the activity id of a previously
+            sent activity given back to the bot as the response from a send call.
+            When the :meth:'ActivityHandler.on_turn()` method receives a message reaction activity, it calls this
+            method.
+            If the message reaction indicates that reactions were added to a message, it calls
+            :meth:'ActivityHandler.on_reaction_added().
+            If the message reaction indicates that reactions were removed from a message, it calls
+            :meth:'ActivityHandler.on_reaction_removed().
             In a derived class, override this method to add logic that applies to all message reaction activities.
-            Add logic to apply before the reactions added or removed logic before the call to the this base class method.
+            Add logic to apply before the reactions added or removed logic before the call to the this base class
+            method.
             Add logic to apply after the reactions added or removed logic after the call to the this base class method.
         """
         if turn_context.activity.reactions_added is not None:
@@ -225,7 +238,8 @@ async def on_reactions_removed(  # pylint: disable=unused-argument
 
     async def on_event_activity(self, turn_context: TurnContext):
         """
-        Invoked when an event activity is received from the connector when the base behavior of :meth:'ActivityHandler.on_turn()` is used.
+        Invoked when an event activity is received from the connector when the base behavior of
+        :meth:'ActivityHandler.on_turn()` is used.
 
         :param turn_context: The context object for this turn
         :type turn_context: :class:`TurnContext`
@@ -254,7 +268,8 @@ async def on_token_response_event(  # pylint: disable=unused-argument
         self, turn_context: TurnContext
     ):
         """
-        Invoked when a `tokens/response` event is received when the base behavior of :meth:'ActivityHandler.on_event_activity()` is used.
+        Invoked when a `tokens/response` event is received when the base behavior of
+        :meth:'ActivityHandler.on_event_activity()` is used.
         If using an `oauth_prompt`, override this method to forward this activity to the current dialog.
 
         :param turn_context: The context object for this turn
@@ -263,8 +278,9 @@ async def on_token_response_event(  # pylint: disable=unused-argument
         :returns: A task that represents the work queued to execute
 
         .. note::
-            When the :meth:'ActivityHandler.on_event()` method receives an event with an activity name of `tokens/response`,
-            it calls this method. If your bot uses an `oauth_prompt`, forward the incoming activity to the current dialog.
+            When the :meth:'ActivityHandler.on_event()` method receives an event with an activity name of
+            `tokens/response`, it calls this method. If your bot uses an `oauth_prompt`, forward the incoming
+            activity to the current dialog.
         """
         return
 
@@ -304,8 +320,8 @@ async def on_unrecognized_activity_type(  # pylint: disable=unused-argument
         self, turn_context: TurnContext
     ):
         """
-        Invoked when an activity other than a message, conversation update, or event is received when the base behavior of
-        :meth:`ActivityHandler.on_turn()` is used.
+        Invoked when an activity other than a message, conversation update, or event is received when the base
+        behavior of :meth:`ActivityHandler.on_turn()` is used.
         If overridden, this method could potentially respond to any of the other activity types.
 
         :param turn_context: The context object for this turn
@@ -314,7 +330,7 @@ async def on_unrecognized_activity_type(  # pylint: disable=unused-argument
         :returns: A task that represents the work queued to execute
 
         .. note::
-            When the :meth:`ActivityHandler.on_turn()` method receives an activity that is not a message, conversation update, message reaction,
-            or event activity, it calls this method.
+            When the :meth:`ActivityHandler.on_turn()` method receives an activity that is not a message,
+            conversation update, message reaction, or event activity, it calls this method.
         """
         return
diff --git a/libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py b/libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py
@@ -90,7 +90,8 @@ def __init__(
         :param app_id: The bot application ID. This is the appId returned by the Azure portal registration, and is
         the value of the `MicrosoftAppId` parameter in the `config.py` file.
         :type app_id: str
-        :param app_password: The bot application password. This is the password returned by the Azure portal registration, and is
+        :param app_password: The bot application password. This is the password returned by the Azure portal
+        registration, and is
         the value os the `MicrosoftAppPassword` parameter in the `config.py` file.
         :type app_password: str
         :param channel_auth_tenant: The channel tenant to use in conversation
@@ -674,7 +675,8 @@ async def get_conversations(self, service_url: str, continuation_token: str = No
         returns results in pages and each page will include a `continuationToken` that can be used to fetch the next
         page of results from the server.
 
-        :param service_url: The URL of the channel server to query. This can be retrieved from `context.activity.serviceUrl`
+        :param service_url: The URL of the channel server to query. This can be retrieved from
+        `context.activity.serviceUrl`
         :type service_url: str
 
         :param continuation_token: The continuation token from the previous page of results
@@ -684,8 +686,10 @@ async def get_conversations(self, service_url: str, continuation_token: str = No
 
         :return: A task that represents the work queued to execute
 
-        .. note:: If the task completes successfully, the result contains a page of the members of the current conversation.
-        This overload may be called from outside the context of a conversation, as only the bot's service URL and credentials are required.
+        .. note:: If the task completes successfully, the result contains a page of the members of the current
+        conversation.
+        This overload may be called from outside the context of a conversation, as only the bot's service URL and
+        credentials are required.
         """
         client = await self.create_connector_client(service_url)
         return await client.conversations.get_conversations(continuation_token)
diff --git a/libraries/botbuilder-dialogs/botbuilder/dialogs/dialog_reason.py b/libraries/botbuilder-dialogs/botbuilder/dialogs/dialog_reason.py
@@ -13,7 +13,8 @@ class DialogReason(Enum):
     :vartype ContinueCalled: int
     :var EndCalled: A dialog ended normally through a call to `DialogContext.end_dialog()
     :vartype EndCalled: int
-    :var ReplaceCalled: A dialog is ending because it's being replaced through a call to `DialogContext.replace_dialog()`.
+    :var ReplaceCalled: A dialog is ending because it's being replaced through a call to
+    `DialogContext.replace_dialog()`.
     :vartype ReplacedCalled: int
     :var CancelCalled: A dialog was cancelled as part of a call to `DialogContext.cancel_all_dialogs()`.
     :vartype CancelCalled: int
diff --git a/libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/prompt.py b/libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/prompt.py
@@ -215,7 +215,6 @@ async def on_prompt(
         :return: A :class:Task representing the asynchronous operation.
         :rtype: :class:Task
         """
-        pass
 
     @abstractmethod
     async def on_recognize(
@@ -238,7 +237,6 @@ async def on_recognize(
         :return: A :class:Task representing the asynchronous operation.
         :rtype: :class:Task
         """
-        pass
 
     def append_choices(
         self,
