Skip to content

Fix NRE when VS is not installed.#99

Merged
jkoritzinsky merged 1 commit intomasterfrom
sdk-nre
Jan 2, 2019
Merged

Fix NRE when VS is not installed.#99
jkoritzinsky merged 1 commit intomasterfrom
sdk-nre

Conversation

@jkoritzinsky
Copy link
Member

Fix #94.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #99 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   58.61%   58.57%   -0.05%     
==========================================
  Files         150      150              
  Lines        9168     9168              
  Branches     1123     1123              
==========================================
- Hits         5374     5370       -4     
- Misses       3406     3408       +2     
- Partials      388      390       +2
Impacted Files Coverage Δ
SharpGen/Parser/SdkResolver.cs 56% <66.66%> (ø) ⬆️
SharpGen/Model/CsMarshalBase.cs 70.83% <0%> (-4.17%) ⬇️
SharpGen/Model/CppElement.Extensions.cs 44.23% <0%> (-1.93%) ⬇️
SharpGen/Parser/CppParser.cs 76.06% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc53f49...ce71349. Read the comment docs.

@jkoritzinsky jkoritzinsky merged commit a11088e into master Jan 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the sdk-nre branch January 2, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant