Skip to content

Add RaiseException callback - #154

Merged
jkoritzinsky merged 7 commits into
SharpGenTools:servicing/1.2.xfrom
danwalmsley:feature/exception-callback
Jan 19, 2020
Merged

Add RaiseException callback#154
jkoritzinsky merged 7 commits into
SharpGenTools:servicing/1.2.xfrom
danwalmsley:feature/exception-callback

Conversation

@danwalmsley

@danwalmsley danwalmsley commented Jan 6, 2020

Copy link
Copy Markdown

This needs to target a branch at the 1.2 label.

@danwalmsley
danwalmsley marked this pull request as ready for review January 6, 2020 10:48
@danwalmsley

danwalmsley commented Jan 6, 2020

Copy link
Copy Markdown
Author

Generates code such as:

                try
                {
                    ...  
                }
                catch (System.Exception __exception__)
                {
                    CallbackInterface @this = (CallbackInterface)ToShadow<Interface.CallbackInterfaceShadow>(thisObject).Callback;
                    (@this as SharpGen.Runtime.IExceptionCallback)?.RaiseException(__exception__);
                    return default (System.Byte);
                }

@danwalmsley danwalmsley changed the title WIP: Add RaiseException callback Add RaiseException callback Jan 6, 2020
@jkoritzinsky
jkoritzinsky changed the base branch from master to servicing/1.2.x January 12, 2020 19:47

@jkoritzinsky jkoritzinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make another PR that goes into master implementing the same feature? We're using a dual-checkin model for servicing.

@danwalmsley

Copy link
Copy Markdown
Author

#155

targets master

@jkoritzinsky
jkoritzinsky merged commit 799ed6b into SharpGenTools:servicing/1.2.x Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants