Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Fix number with leading zeros serialization bug #445

Merged
mythz merged 1 commit into from
Apr 8, 2015
Merged

Fix number with leading zeros serialization bug #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ServiceStack.Text/JsonObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public string Child(string key)
return base[key];
}

static readonly Regex NumberRegEx = new Regex(@"^[0-9]*(?:\.[0-9]*)?$", PclExport.Instance.RegexOptions);
static readonly Regex NumberRegEx = new Regex(@"^(0|[1-9]*)(?:\.[0-9]*)?$", PclExport.Instance.RegexOptions);

/// <summary>
/// Write JSON Array, Object, bool or number values as raw string
Expand Down
21 changes: 21 additions & 0 deletions tests/ServiceStack.Text.Tests/JsonTests/JsonObjectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,27 @@ public void Can_parse_empty_object_with_mixed_whitespaces()
Assert.That(JsonObject.Parse("{ \n\t \n\r}"), Is.Empty);
}

[Test]
public void Can_Serialize_numbers()
{
string notNumber = "{\"field\":\"00001\"}";
Assert.AreEqual(notNumber, JsonObject.Parse(notNumber).ToJson<JsonObject>());

string num1 = "{\"field\":0}";
Assert.AreEqual(num1, JsonObject.Parse(num1).ToJson<JsonObject>());

string num2 = "{\"field\":0.5}";
Assert.AreEqual(num2, JsonObject.Parse(num2).ToJson<JsonObject>());

string num3 = "{\"field\":.5}";
Assert.AreEqual(num3, JsonObject.Parse(num3).ToJson<JsonObject>());

string num4 = "{\"field\":12312}";
Assert.AreEqual(num4, JsonObject.Parse(num4).ToJson<JsonObject>());

string num5 = "{\"field\":12312.1231}";
Assert.AreEqual(num5, JsonObject.Parse(num5).ToJson<JsonObject>());
}

public class Jackalope
{
Expand Down