Skip to content

Remove extra semi-colon from step.css also - #77

Closed
sahi1422 wants to merge 1 commit into
Semantic-Org:masterfrom
sahi1422:fix-webpack5-build-issue
Closed

Remove extra semi-colon from step.css also#77
sahi1422 wants to merge 1 commit into
Semantic-Org:masterfrom
sahi1422:fix-webpack5-build-issue

Conversation

@sahi1422

@sahi1422 sahi1422 commented Dec 17, 2021

Copy link
Copy Markdown
Contributor

@jlukic @levithomason , I forgot to remove the semi-colon from the step.css

#76

@randadam

Copy link
Copy Markdown

Is there a reason this is still open? I can confirm this is the same exact edit I have to do to get it working with webpack 5.

@R3DST0RM

Copy link
Copy Markdown

Are there any updates on why this isn't merged yet?

@guslen

guslen commented Sep 15, 2022

Copy link
Copy Markdown

@fniessink or maybe @peacekeeper or @sahi1422 ?
Also, a version bump would be awesome, @sahi1422

@guslen

guslen commented Sep 16, 2022

Copy link
Copy Markdown

@jlukic will you merge this? Also, a version bump would be excellent. 😄

@guslen

guslen commented Sep 20, 2022

Copy link
Copy Markdown

@peacekeeper, do you know who can merge this pull request?

@peacekeeper

Copy link
Copy Markdown

Sorry I don't know.. I also wish this could be merged.

@guslen

guslen commented Sep 20, 2022

Copy link
Copy Markdown

@peacekeeper

Sorry I don't know.. I also wish this could be merged.

I sent an email to info@semantic-ui.com with this content:
Subject:

Who can merge PR in Semantic css

Content:

Hi,
We need a merge and a version bump for semantic-ui-css. jlucik @jlukic doesn't seem to react even after tagging him. I don't know who is in charge of the repo.
this is the PR in question #77 (comment)

Thank you for the help.

Best regards,
Gustav Lennart Voigt

@jlukic

jlukic commented Sep 20, 2022

Copy link
Copy Markdown
Member

These repos are automatically generated from the main Semantic UI repo with a release bot.

You will need to make any PR requests off the main repo src/ folder if there's a typo.

You can find the correct file here
https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/step.overrides#L5

@jlukic

jlukic commented Oct 6, 2022

Copy link
Copy Markdown
Member

I've gone ahead and run the release bot to publish the changes from the main repo @sahi1422

@jlukic jlukic closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants