[Snyk] Security upgrade org.apache.logging.log4j:log4j-core from 2.8.2 to 2.25.3 #55
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-14532782
Summary of ChangesHello @franksec42, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the project's security by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request from Snyk upgrades org.apache.logging.log4j:log4j-core to fix a security vulnerability. While the upgrade is necessary, the large version jump from 2.8.2 to 2.25.3 introduces a potential breaking change. Specifically, Log4j 2.9 and later versions changed log4j-api from a compile-time to a runtime dependency of log4j-core. To prevent potential build failures, it's critical to explicitly add logaj-api as a dependency. I have provided a suggestion to address this.
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| <version>2.8.2</version> | ||
| <version>2.25.3</version> | ||
| </dependency> |
There was a problem hiding this comment.
Upgrading log4j-core from 2.8.2 to 2.25.3 crosses a significant change boundary. Starting with Log4j 2.9, log4j-api is no longer a compile-time transitive dependency of log4j-core; it is now a runtime dependency. To ensure the application continues to compile and run without issues, you should explicitly declare a dependency on log4j-api with the same version as log4j-core. This is necessary if any part of your codebase or any other dependency uses the Log4j API directly.
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
<version>2.25.3</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
<version>2.25.3</version>
</dependency>
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Apache Log4j Core dependency from version 2.8.2 to 2.25.3 to address a medium severity security vulnerability (Improper Validation of Certificate with Host Mismatch, SNYK-JAVA-ORGAPACHELOGGINGLOG4J-14532782).
Key Changes:
- Updates
org.apache.logging.log4j:log4j-corefrom version 2.8.2 to 2.25.3 in pom.xml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Snyk has created this PR to fix 1 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):
pom.xmlVulnerabilities that will be fixed with an upgrade:
SNYK-JAVA-ORGAPACHELOGGINGLOG4J-14532782
2.8.2->2.25.3No Path FoundNo Known ExploitImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.