Skip to content

Docs/len update readme#20

Merged
jlenon7 merged 13 commits intomainfrom
docs/len-update-readme
Feb 11, 2022
Merged

Docs/len update readme#20
jlenon7 merged 13 commits intomainfrom
docs/len-update-readme

Conversation

@jlenon7
Copy link
Contributor

@jlenon7 jlenon7 commented Feb 11, 2022

Proposed changes

  • Just updating README to show how to use .middleware method on Router.
  • Little fix on route method of Router to not get the controller handler, when handler has dots on it.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@jlenon7 jlenon7 added documentation Improvements or additions to documentation fix Fix something that is not working labels Feb 11, 2022
@jlenon7 jlenon7 requested a review from txsoura February 11, 2022 18:28
@jlenon7 jlenon7 self-assigned this Feb 11, 2022
@jlenon7 jlenon7 merged commit 2ac5514 into main Feb 11, 2022
@jlenon7 jlenon7 deleted the docs/len-update-readme branch February 11, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fix Fix something that is not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant