New color picker for My stuff and Messages tab banners in dark-www. Only works with scratchr2. - #9096
Open
skima-a wants to merge 2 commits into
Open
New color picker for My stuff and Messages tab banners in dark-www. Only works with scratchr2.#9096skima-a wants to merge 2 commits into
skima-a wants to merge 2 commits into
Conversation
pufferfish101007
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self explanatory. Changes the addon file for dark-www, adding a new color picker that lets you change the banner color for the "My stuff" tab, the "Messages" tab, and the main scratch page (pre login). These banners (with the exception of the main scratch page) only appear with the scratchr2 extension.
0629.mp4
### Reason for changes:
As of now, the mentioned banners can only be less saturated versions of the navbar color. For some navbar colors this looks fine, but with colors like orange it can look ugly. This new color picker allows the user to choose what color they want instead of only having 3 options.
This doesn't have to be in dark-www and can be moved to scratchr2 if requested.
This change was tested and low and behold, the 15 lines of code I changed didn't break anything. This change also changes the color of the "Next" button on the sign up page.