block-duplicate: use return value of stripIds - #9003
Merged
Conversation
mxmou
added
scope: addon
Member
|
I saw the stripids thing yesterday and was like huh that sounds relevant. But didn't piece together it would break your fix. |
Member
|
You can request me to review you know if you want something done faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
There's an open PR in scratch-blocks that changes
stripIds()to create a new object instead of mutating the argument, which will break the cursed inputs fix introduced in #8997. This PR updates the code that callsstripIds()to use the returned value if there's one.Tests
Verified that the cursed inputs bug is still fixed on scratch.mit.edu and on the fix/stripIds-mutation branch of scratch-blocks.