Website themes: better support for deleted and reported comments #8832
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The contrast of '7 days ago' text looks to me as if it is quite a bit worse on the scratchr2 example than it was before. Would it be possible to alter the colour of the text (or the background) to improve this? (I'm not sure how this related to any vanilla scratch theming, if any - if scratch already does this then please ignore) (However it is much better in the dark-www example!) |
Member
Author
|
The contrast is the same as on vanilla 3.0-styled pages, but I can improve it slightly by using transparent black instead of light gray (so that it will automatically be darker on the red background than on white). |
Member
Author
|
Now it looks like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8727
Changes
Project and studio pages with dark-www
Before:
After:
Profile page with scratchr2
Before:
After:
(I didn't actually delete or report either of those comments)
Tests
Tested on Edge with different combinations of addons.