Skip to content

Fix CSS selectors after update#8806

Merged
Samq64 merged 5 commits intoScratchAddons:masterfrom
Samq64:stage-css-fixes
Jan 30, 2026
Merged

Fix CSS selectors after update#8806
Samq64 merged 5 commits intoScratchAddons:masterfrom
Samq64:stage-css-fixes

Conversation

@Samq64
Copy link
Member

@Samq64 Samq64 commented Jan 30, 2026 •
edited
Loading

Resolves #8799
Resolves #8800
Resolves #8801
Resolves #8802

Changes

Fixes some CSS selectors after a Scratch update.

Tests

Tested on Helium.

@Samq64 Samq64 added type: bug A bug in the addon loader, or in a specific addon scope: addon Related to one or multiple addons labels Jan 30, 2026
@Samq64
Copy link
Member Author

Samq64 commented Jan 30, 2026

It may also be a good idea to wrap the pause icon in a <button> element for consistency with Scratch.

@Samq64 Samq64 added the scope: upstream Related to something we depend on (like Scratch, a library, or the browser) label Jan 30, 2026
@Samq64 Samq64 changed the title Fix editor-stage-left & editor-buttons-reverse-order Fix CSS selectors after update Jan 30, 2026
@DNin01 DNin01 added this to the v1.45.0 milestone Jan 30, 2026
mxmou
mxmou approved these changes Jan 30, 2026
View reviewed changes
Copy link
Member

@mxmou mxmou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bugs, but there are a few additional changes that could be made to prevent them from happening again.

addons/editor-stage-left/stageleft.css
margin-right: calc(0.5rem / 2);
margin-left: 0;
}
[class^="gui_flex-wrapper"] {
Copy link
Member

@mxmou mxmou Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many selectors in this file and others that use ^= instead of *=. I think they should all be changed (in a separate PR).

@Samq64 @mxmou
Remove element type from selectors
c1f5e87 
Co-authored-by: Maximouse <mxmou.mouse@gmail.com>
@Samq64 Samq64 merged commit 78fe483 into ScratchAddons:master Jan 30, 2026
2 checks passed
@Samq64 Samq64 deleted the stage-css-fixes branch January 30, 2026 20:00
@Quilant
Copy link

Quilant commented Jan 31, 2026 •
edited
Loading

why is v1.45.0 included instead of v1.44.5?

@Samq64
Copy link
Member Author

Samq64 commented Jan 31, 2026

@WorldLanguages Should this be backported or are you ready to ship 1.45? You mentioned there would be a new release at the end of January in #8751 but I also understand if you are busy.

@WorldLanguages
Copy link
Member

WorldLanguages commented Jan 31, 2026

@Samq64 Hi, I'll probably release a hotfix instead so that we can get it done faster. (web store reviews also take less time if there's less lines changed)

@DNin01
Copy link
Member

DNin01 commented Jan 31, 2026

@WorldLanguages Here are four other fixes you could release:

WorldLanguages pushed a commit that referenced this pull request Jan 31, 2026
@Samq64 @mxmou @WorldLanguages
Fix CSS selectors after Scratch update (#8806)
e2d5d9b 
* Fix editor-stage-left & editor-buttons-reverse-order

* Fix costume drag and drop

* Format code

* Fix hide-delete-button

* Remove element type from selectors

Co-authored-by: Maximouse <mxmou.mouse@gmail.com>

---------

Co-authored-by: Samq64 <Samq64@users.noreply.github.com>
Co-authored-by: Maximouse <mxmou.mouse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxmou mxmou mxmou approved these changes

Assignees

No one assigned

Labels

scope: addon Related to one or multiple addons scope: upstream Related to something we depend on (like Scratch, a library, or the browser) type: bug A bug in the addon loader, or in a specific addon

Projects

None yet

Milestone

v1.45.0

5 participants

@Samq64 @Quilant @WorldLanguages @DNin01 @mxmou