Skip to content

Conversation

@DNin01
Copy link
Member

@DNin01 DNin01 commented Nov 22, 2025

Resolves (from #8577):

Navigate between addons with the arrow keys

Changes

Before, the handles used to reorder table rows in addon settings only responded to mouse input. Now, you can focus the handle and press the up and down arrow keys to move the table row. When using a screen reader, the handle is supposed to work like a spin button, which also allows items to be moved incrementally.

Reason for changes

For better accessibility.

I don't know if this is usually how moving items works, but it'll do.

Tests

Changes tested using Windows Narrator and Edge.

- Table rows can now be reordered using the arrow keys, not just a mouse
- Table row handles are announced as spin buttons to screen readers
- Table row handles are now hidden on single-row tables
@DNin01 DNin01 requested review from Samq64 and mxmou November 22, 2025 02:39
@DNin01 DNin01 added type: enhancement New feature for the project scope: webpages Related to the web pages (settings page, pop-up, etc) scope: accessibility Addresses an accessibility issue labels Nov 22, 2025
@Samq64
Copy link
Member

Samq64 commented Nov 22, 2025

I was thinking of replacing the handle with up and down arrows and moving the X to the top right but this also works.

@DNin01 DNin01 added this to the v1.45.0 milestone Dec 7, 2025
@DNin01
Copy link
Member Author

DNin01 commented Dec 7, 2025

I was thinking of replacing the handle with up and down arrows

The reason I tried out a spin button is so that the UI wouldn't have to change depending on whether you were using a keyboard or a mouse—it was a creative solution.

@mxmou
Copy link
Member

mxmou commented Dec 10, 2025

I don't know if this is usually how moving items works, but it'll do.

I think it would be a good idea to compare this implementation with a few other apps and websites - if there's an established pattern, we should follow it instead of inventing something else.

For example, in the Language & region page in Windows settings, the drag handles don't get keyboard focus. Instead, there's a dropdown menu with "move up" and "move down" options:
image

@DNin01 DNin01 modified the milestones: v1.45.0, v1.46.0 Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: accessibility Addresses an accessibility issue scope: webpages Related to the web pages (settings page, pop-up, etc) type: enhancement New feature for the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants