-
Notifications
You must be signed in to change notification settings - Fork 418
Settings page keyboard navigation #8577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1c04fc5
Use checkbox elements for addon toggles, share styles
Samq64 9073ad2
Fix keyboard navigation in headers and sidebar
Samq64 c170d0b
More settings: use native dialog element
Samq64 02b693e
Convert more divs to buttons
Samq64 850a2d9
Format code
Samq64 410dede
Make list items tabbable
DNin01 48c4615
More accessibile arrow buttons, consolidate more styles
Samq64 cc091f8
Temporary dropdown solution
Samq64 f70b3a6
Don't focus disabled addon elements
Samq64 599d4bd
Format code
Samq64 39864a1
Dropdown component
Samq64 787f12d
Dropdown arrow navigation
Samq64 edc5780
Format code
Samq64 c2ba9e1
Fix icon margin in more settings
Samq64 66e98c9
Fix toggling addons with permssions/confirmation
Samq64 a5e8497
Give more buttons titles, focusable setting tooltips
Samq64 384efd6
Fix dropdowns not closing when clicking outside
Samq64 e553602
Format code
Samq64 7afdc5b
Start working on Scratch messaging
Samq64 93583ae
Format code
Samq64 2f0b39a
Delete and post comments with the keyboard
Samq64 7deebc6
Format code
Samq64 656227d
Always show dismiss button
Samq64 c5522f1
Shorter dropdown title
Samq64 2abdc7e
Apply Maximouse's suggestions
Samq64 167c790
Format code
Samq64 9468996
Forgot one
Samq64 4b7d405
Minor cleanup
Samq64 a1b0160
Apply suggestions from code review
Samq64 8f60587
Revert unnecessary messaging changes
Samq64 3282e7d
Fix bugs
Samq64 c705459
Format code
Samq64 83d0c24
Consistent disabled state naming
Samq64 b7feae4
margin-inline consistency with master
Samq64 3e634af
Fix split button highlight
Samq64 2172c15
Fix tab and category oulines
Samq64 fb0326c
Apply to header as well
Samq64 5316d63
filter-option as well
Samq64 1a953a8
Tabbable tags, autofocus first dropdown item
Samq64 0aaba64
Trun select options into radio input elements
Samq64 78c6139
Refine radio buttons
DNin01 b73e7e3
Apply to other sidebar toggle button
Samq64 8f75c7f
Format code
Samq64 be5f450
Focus before button when shift-tabbing in dropdown
Samq64 bdde59e
flex-grow on div
Samq64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.