dark-www & scratch3to2: style new "Set Thumbnail" button & modal #8451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmou
added
scope: addon
Member
|
?!!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!??!?!!?!?!?!?!??!?!?!?!?!?!? |
agreed |
Member
Author
|
@WorldLanguages I think we should try at least to release this before the Scratch update - otherwise users with dark mode won't be able to read the popup explaining the new feature. The other two PRs aren't as important. |
Member
And remember, we can always release a minor update if v1.43.0 isn't quite ready yet. |
Member
Sure |
WorldLanguages
pushed a commit
that referenced
this pull request
Jul 21, 2025
WorldLanguages
pushed a commit
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
Scratch will add a "Set Thumbnail" button on the project page.
Tests
Tested locally on Edge.
The modal normally only opens when the button is clicked for the first time. To open it again, delete the
isFirstManualThumbnailUpdatekey in localStorage and reload the page.