editor-theme3, number-pad: new Blockly #7922
Conversation
mxmou
added
scope: addon
|
Hat blocks become flat after dynamically changing theme3's settings and dragging the block. |
|
The dial is inconsistent between Scratch versions with some settings. I made sure Scratch's high contrast mode was off before enabling the addon. On the Scratch website: And on new Blockly: |
On the current version of Scratch, the dial isn't affected by Scratch's high contrast mode and the addon doesn't change it either. This was changed in the new version and I think the way it looks with the addon is correct - the high contrast preset, for example, is identical to Scratch's high contrast mode: |
| Blockly.FieldNote.prototype.addOctaveButton_ = function (...args) { | ||
| let FieldNote; | ||
| if (Blockly.registry) FieldNote = Blockly.registry.getClass(Blockly.registry.Type.FIELD, "field_note"); | ||
| FieldNote = Blockly.FieldNote; |
There was a problem hiding this comment.
@mxmou If FieldNote always gets set to a predetermined value, then the if-statement above will ultimately have no effect. Was there supposed to be an else keyword on this line?
4 participants
Changes
Updates "customizable block colors" and "always show number pad" to work with the new version of Blockly.
Tests
Tested both Scratch versions on Edge and Firefox.