Add option to custom-block-shape for flat hat blocks#7781
Closed
TheColaber wants to merge 6 commits intoScratchAddons:masterfrom
Closed
Add option to custom-block-shape for flat hat blocks#7781TheColaber wants to merge 6 commits intoScratchAddons:masterfrom
custom-block-shape for flat hat blocks#7781TheColaber wants to merge 6 commits intoScratchAddons:masterfrom
Conversation
Samq64
added
type: enhancement
Member
|
Shouldn't this be separated from the cat block changes (#7589)? |
Member
Author
|
they indirectly affect each other since they both affect block constants. try enabling cat blocks and then dynamically enabling and disabling this addon. you'll see floating ears. when the pr mentioned is merged, no floating ears :) |
mxmou
removed
the
status: pending
Member
|
#8556 rewrote the userscript for modern Blockly only keeping this one for backwards compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5886. Exceeds #5879
This commit shows the changes to custom block shape: 0597c12
This PR depends on #7589. That PR should get merged first.
This also changes the flat presets to use this new flat setting. May need transition code to enable this setting for old users?