Skip to content

New-ish addon: Redirect to standard forums (from mobile forums 404) - #6915

Merged
WorldLanguages merged 15 commits into
ScratchAddons:masterfrom
iqnite:remove-redirect-mobile-forums
Mar 14, 2024
Merged

New-ish addon: Redirect to standard forums (from mobile forums 404)#6915
WorldLanguages merged 15 commits into
ScratchAddons:masterfrom
iqnite:remove-redirect-mobile-forums

Conversation

@iqnite

@iqnite iqnite commented Nov 30, 2023

Copy link
Copy Markdown
Contributor

Resolves #6910
Closes #6917

Changes

  • Remove the redirect-mobile-forums addon
  • New! Attempt to redirect to the standard forums from 404 pages caused by discuss/m/
  • Remove scripts that were exclusively for mobile devices
  • Remove CSS rulesets that were exclusively for mobile devices
  • New! Make the addon enabled by default
  • New! Change the addon's ID to smart-404

Reason for changes

Scratch no longer supports the discuss/m/ forums, so why should Scratch Addons support them? Still, there are links to the mobile forums, which cause 404 errors.

Tests

Redirecting from 404 pages works.
I broadly tested the other addons where I removed the rulesets and scripts and I didn't notice any bugs. (I wrote this addon at 10 pm, so if anybody else could take a closer look at them?)
For the same reason, I kept the dark-www settings for mobile forums, as I'm not sure if it would still work.

@ghost

ghost commented Nov 30, 2023

Copy link
Copy Markdown

Just as a note: It should probably be worth seeing if it was only a temporary removal, though it might be unlikely

@DNin01

DNin01 commented Nov 30, 2023

Copy link
Copy Markdown
Member

Just as a note: It should probably be worth seeing if it was only a temporary removal, though it might be unlikely

Yeah, there is a small chance that they might come back soon, but my guess is they are gone. Wait a few weeks, perhaps?

@Chiroyce1

Copy link
Copy Markdown
Contributor

If they have decided on removing it entirely, it only makes this addon more useful by redirecting any old mobile links either on Scratch itself or more commonly Google search, see #6917

@iqnite

iqnite commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

I know, I set up this PR to be ready then. But the addon could also be modified to redirect to the forums instead of showing a 404 page when people click on a mobile forum link.

@Samq64 Samq64 added the scope: addon Related to one or multiple addons label Dec 1, 2023
@BroJac5246

Copy link
Copy Markdown
Contributor

If they have decided on removing it entirely, it only makes this addon more useful by redirecting any old mobile links either on Scratch itself or more commonly Google search, see #6917

Maybe we should rename the old addon and make it enabled by default since there's no reason not to enable it.

@medlans

medlans commented Dec 3, 2023

Copy link
Copy Markdown

Just as a note: It should probably be worth seeing if it was only a temporary removal, though it might be unlikely

I think Paddle2See stated somewhere that they were removed for security, so doesn’t seem temporary. Though I think the addon should be kept since there’s still search results and maybe past posts that have the mobile forums.

@Samq64

Samq64 commented Dec 6, 2023

Copy link
Copy Markdown
Member

Could redirect-mobile-forums be re-added? Also the forum match can be simplified.

@iqnite iqnite changed the title Deprecate mobile forums Deprecate mobile forums and automatically redirect to main Dec 11, 2023
@iqnite

iqnite commented Dec 11, 2023

Copy link
Copy Markdown
Contributor Author

Update: Based on user feedback, I've added back the addon, and augmented its functionality so that it automatically redirects from 404 pages that were invoked from mobile forum links.
It has the potential to become a "Smart 404" addon... (flashbacks from SA Nightly)

@Samq64 Samq64 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6917 was actually a PR for the redirect-mobile-forums changes, I just wanted it added back the way it was so there wouldn't be any conflicts, but now that it's done it could also just be closed when this is merged instead.

Comment thread addons/redirect-mobile-forums/addon.json Outdated
Comment thread addons/redirect-mobile-forums/userscript.js Outdated
Shortened syntax.

Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
@iqnite

iqnite commented Dec 12, 2023

Copy link
Copy Markdown
Contributor Author

Should we change the addon's ID to smart-404? That way, it would be enabled by default for new and existing users.

@Samq64
Samq64 self-requested a review December 15, 2023 20:57
@WorldLanguages

Copy link
Copy Markdown
Member

Should we change the addon's ID to smart-404? That way, it would be enabled by default for new and existing users.

I wouldn't name it smart-404 unless we actually plan to implement a smart 404 feature. You can consider just adding -v2 at the end of the addon name.

@iqnite

iqnite commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

But if somebody wants to build a smart 404 mechanism for other pages, they can it on this addon.

@BroJac5246

BroJac5246 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

But if somebody wants to build a smart 404 mechanism for other pages, they can it on this addon.

If an addon's scope is expanded, it generally keeps the ID that refers to the old function. Anticipating a Smart 404s addon and changing the ID to that would not follow this custom, so the ID shouldn't be changed unless it is determined (before this or other similar PRs are merged) that the addon's scope should be expanded. That's not too say it won't happen, but as of now just -v2 should be added to the ID.

@Samq64 Samq64 added the status: needs review PR needs 1 more approval label Dec 21, 2023
Comment thread addons/redirect-mobile-forums-v2/addon.json Outdated
@DNin01 DNin01 added this to the v1.36.0 milestone Jan 31, 2024
Comment thread addons/necropost-highlighter/userscript.js Outdated

@DNin01 DNin01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've probably tested this a little more, but I don't want to keep us waiting. This looks good enough.

@DNin01 DNin01 removed the status: needs review PR needs 1 more approval label Feb 16, 2024
Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
@WorldLanguages

Copy link
Copy Markdown
Member

Sorry I forgot to move the milestone. Strings are closed right now, so we can't add new addons (technically it's not new, but the addon ID is new, so all translations are lost)

@WorldLanguages WorldLanguages modified the milestones: v1.36.0, v1.37.0 Feb 18, 2024
@DNin01 DNin01 mentioned this pull request Mar 3, 2024
3 tasks
@Samq64

Samq64 commented Mar 11, 2024

Copy link
Copy Markdown
Member

Is this ready to merge then?

@WorldLanguages

Copy link
Copy Markdown
Member

I think we forgot to update the regexes on addons/necropost-highlighter/addon.json that still consider the mobile forums

@WorldLanguages

WorldLanguages commented Mar 14, 2024

Copy link
Copy Markdown
Member

Could redirect-mobile-forums be re-added? Also the forum match can be simplified.

That too

However, the actual goal of this PR is not to remove all references to the mobile forums.

@WorldLanguages WorldLanguages changed the title Deprecate mobile forums and automatically redirect to main New-ish addon: Redirect to standard forums (from mobile forums 404) Mar 14, 2024
@WorldLanguages
WorldLanguages merged commit dbd1d13 into ScratchAddons:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: addon Related to one or multiple addons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the "redirect to standard forums" addon (&/or inclusions of the mobile forums in addons)

7 participants