New-ish addon: Redirect to standard forums (from mobile forums 404) - #6915
Conversation
|
Just as a note: It should probably be worth seeing if it was only a temporary removal, though it might be unlikely |
Yeah, there is a small chance that they might come back soon, but my guess is they are gone. Wait a few weeks, perhaps? |
|
If they have decided on removing it entirely, it only makes this addon more useful by redirecting any old mobile links either on Scratch itself or more commonly Google search, see #6917 |
|
I know, I set up this PR to be ready then. But the addon could also be modified to redirect to the forums instead of showing a 404 page when people click on a mobile forum link. |
Maybe we should rename the old addon and make it enabled by default since there's no reason not to enable it. |
I think Paddle2See stated somewhere that they were removed for security, so doesn’t seem temporary. Though I think the addon should be kept since there’s still search results and maybe past posts that have the mobile forums. |
|
Could |
This reverts commit 5925baf.
|
Update: Based on user feedback, I've added back the addon, and augmented its functionality so that it automatically redirects from 404 pages that were invoked from mobile forum links. |
Shortened syntax. Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
|
Should we change the addon's ID to |
I wouldn't name it |
|
But if somebody wants to build a smart 404 mechanism for other pages, they can it on this addon. |
If an addon's scope is expanded, it generally keeps the ID that refers to the old function. Anticipating a Smart 404s addon and changing the ID to that would not follow this custom, so the ID shouldn't be changed unless it is determined (before this or other similar PRs are merged) that the addon's scope should be expanded. That's not too say it won't happen, but as of now just |
DNin01
left a comment
There was a problem hiding this comment.
I should've probably tested this a little more, but I don't want to keep us waiting. This looks good enough.
Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
|
Sorry I forgot to move the milestone. Strings are closed right now, so we can't add new addons (technically it's not new, but the addon ID is new, so all translations are lost) |
|
Is this ready to merge then? |
|
I think we forgot to update the regexes on addons/necropost-highlighter/addon.json that still consider the mobile forums |
That too However, the actual goal of this PR is not to remove all references to the mobile forums. |
Resolves #6910
Closes #6917
Changes
Remove theredirect-mobile-forumsaddondiscuss/m/New! Change the addon's ID tosmart-404Reason for changes
Scratch no longer supports the
discuss/m/forums, so why should Scratch Addons support them? Still, there are links to the mobile forums, which cause 404 errors.Tests
Redirecting from 404 pages works.
I broadly tested the other addons where I removed the rulesets and scripts and I didn't notice any bugs. (I wrote this addon at 10 pm, so if anybody else could take a closer look at them?)
For the same reason, I kept the
dark-wwwsettings for mobile forums, as I'm not sure if it would still work.