New "bugfix" tag for addons - #4515
Conversation
|
Okay, added.
…------- Original Message -------
wtorek, 19 kwietnia 2022 14:40, Samq64 ***@***.***> napisał(a):
@Samq64 commented on this pull request.
---------------------------------------------------------------
In [_locales/en/messages.json](#4515 (comment)):
> @@ -188,6 +191,9 @@
"betaTooltip": {
"message": "Keep in mind that this addon might have bugs."
},
+ "bugfixTooltip": {
+ "message": "This addon fix Scratch's bugs!"
⬇️ Suggested change
- "message": "This addon fix Scratch's bugs!"
+ "message": "This addon fix Scratch's bugs!"
"message": "This addon fixes a Scratch bug."
—
Reply to this email directly, [view it on GitHub](#4515 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AVNNBHCYLFUK6R6QXANSEXTVF2ST7ANCNFSM5TYNAXSA).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I didn't mean to post that review. |
it does sound better tho tbh |
|
@mxmou @lisa-wolfgang What do you think about this PR? I'm unsure. We don't allow users to list/filter addons with a tag, so should we create an addon group dedicated to addons that fix Scratch bugs? Enabled, recommended, bugfixes(?), featured, forums, others, beta? |
|
I like the idea of having an addon group without showing the tag on each addon, like what we do for featured addons. Like W_L said, putting the tag directly on the addon in a similar manner as the "updated" tag implies that we're fixing our own bugs, but a group has a more permanent connotation, especially since it would be distanced from the "new addons and updates" sections. However, what I'd like even more is for these addons to be enabled by default. I know that it's been a challenge to come up with a universal solution for indicating our modifications, but I don't think that's the best way to think about it. Every addon is different and will need its own indication, so such a system will need to be flexible. Therefore, I'd suggest the following implementation:
|
I think the tag should be called "bug fix" with a tooltip "this addon fixes a Scratch bug" |
That doesn't solve the issue of being confusable with our own bugs. Tooltips aren't reliable enough. |
I think discussing that is out of scope for this PR, maybe we can create an issue? |
|
If we go ahead with this PR, it would make sense to have a "feature" tag as well, since there's already a tag for themes. |
I don't think that would be very useful - almost every addon would have the tag. |
|
I think we should have an open discussion about the settings page as a whole and deal with this as well as #3955 at the same time 🤔 |
Samq64
added
the
scope: webpages
Samq64
added
the
status: pending
Samq64
removed
the
status: pending
Samq64
added
status: abandoned
|
Should this be closed in favour of #7242? |
|
Okay, let's focus on that one instead. |
6 participants
Resolves #2568 (comment)
Changes
Adds new tag to addons:
don't run duplicated blocksandfix SVG uploadTests
Firefox newest.
Merge before: ScratchAddons/manifest-schema#59