Move project player addons to a top-level category - #3955

@mxmou Do you like this? I'm not convinced. (asking you since you made the issue that suggested this)

There's only one theme in the project player themes, so maybe it would be better to get rid of the project player themes category completely.

Honestly I don't really like this. IMO the project player is part of the editor.

Honestly I don't really like this. IMO the project player is part of the editor.

It's also part of the website.

Manifest: ScratchAddons/manifest-schema#56

In my opinion, I agree with this being a separate category. The player which can be found in 3 places (projects/*/, projects/*/editor, projects/*/embed). I don't think that to change something in an embed, you have to look under the editor section. And @mxmou argued that this could technically also be a website addon since you can find it there too. I think that when most people think of an "editor" addon, they think of scripts that can run on projects/*/editor. However, all of these scripts that run, run on "projects", which are all 3, project page, project editor, and project embed. This is why I think they should have their own category.

I'm not convinced this should be merged, but I was more skeptical a few months ago.

Some issues I see:

1. There's less than 10 projectPlayer addons. And I'm not sure if clones and mouse-pos should be counted, because they only appear when inside the editor, and aren't helpful when viewing someone else's project.
2. The "Scratch Editor Features" would have 3 subcategories instead of four, making it less consistent with Scratch Website Features.
3. The sidebar of the settings page is already filled on low resolution screens. Adding one more button would hide the "more settings" button for some users.

1. There's less than 10 projectPlayer addons. And I'm not sure if clones and mouse-pos should be counted, because they only appear when inside the editor, and aren't helpful when viewing someone else's project.

Clones and mouse-pos are editor addons. I don't think this is an issue - there aren't many popup addons either.

2. The "Scratch Editor Features" would have 3 subcategories instead of four, making it less consistent with Scratch Website Features.

Why is that important? More subcategories can be added later if there are enough addons for the same part of the editor.

3. The sidebar of the settings page is already filled on low resolution screens. Adding one more button would hide the "more settings" button for some users.

The category buttons are very big - reducing all of them to the size of "small" ones (Credits, Help Translate, Send Feedback) would add enough space for adding another button. The header could be slightly smaller too.

Sorry, I forgot to reply.

Clones and mouse-pos are editor addons. I don't think this is an issue - there aren't many popup addons either.

I think I created the popup category because having "message count in extension icon" as a website addon was too weird. It did involve the Scratch website in a way, because the message count is taken from there, but in no way it modifies the Scratch website and it doesn't even link to it.
Having project player addons inside editor addons isn't as weird as that.

Why is that important? More subcategories can be added later if there are enough addons for the same part of the editor.

Okay, good point. We have tags such as comments but they aren't shown as different subcategories because there's not enough addons with those tags.

The category buttons are very big - reducing all of them to the size of "small" ones (Credits, Help Translate, Send Feedback) would add enough space for adding another button. The header could be slightly smaller too.

That could work.

Am I missing any addon that could fit into this category? I previously said clones and mouse-pos are targeted for developing a project, not for watching projects, so those don't really fit. Also, please see what I say at the end about remove-curved-stage-border.

• 60fps
• fullscreen
• gamepad
• mute-project
• pause
• remove-curved-stage-border (would this addon stay as a theme? would we need to create a "themes for project player" subcategory? this one is very confusing)

Done. The project player themes sub-category already existed, but I removed it.

Added "pending" because the spacing of the category selector needs to be reduced first.

This is still on the v1.36 milestone but Vue 3 is on v1.38. Is that the case or is this one also being pushed back to 1.38? I don't mind fixing the merge conflicts.

Is this still planned for 1.37? Both Mxmou and DNin previously approved.

Hmm, I'll be looking at this after the MV3 release. Sorry.

The getEnabledAddons("editor") calls in turbowarp-player and live-featured-project should probably be changed to getEnabledAddons("player").

@Hans5958 For the manifest schema does it need to be a new version or do I edit the existing one?

@Hans5958 For the manifest schema does it need to be a new version or do I edit the existing one?

I'm pretty sure we should bump the schema to a new version. The last schema hasn't changed for a few releases.