editor-devtools: Shortcut to not close the floating find bar
#3703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also support the HTML text input when an input is focused
CST1229
changed the title
editor-devtools: Ctrl+clicking to not close the floating find bareditor-devtools: Shortcut to not close the floating find bar
TheColaber
added
scope: addon
Member
|
Waiting for @griffpatch approval |
Member
|
Griffpatch says we should also consider a "pin" button, but that can be added in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If
CtrlShift is held while clicking on the workspace or dragging a block from the middle-click find bar, it will not be closed. The layer of the floating find bar is also lowered so that it appears below dragged blocks.Reason for changes
A little quality-of-life feature to allow rapid creation of scripts.
Tests
Tested.
This might have some issues combined with block cherry picking, but hopefully it should be fine.