-
Notifications
You must be signed in to change notification settings - Fork 418
New addon: Alt+click drag to duplicate block #3541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should this addon also have a "flip controls" setting, similar to "grab single block with Ctrl key"? It would require you to hold Ctrl as well as Shift to duplicate the whole stack, and would duplicate a single script by default. |
|
Okay, I'm talking with griffpatch and we might actually want to use Alt instead of Shift, which makes way more sense. But we'd first need to fix the hotkey madness. So I'm not really rushed to merge this. Currently, devtools uses Alt+Click for everything middle click, that is:
The first one is probably not widely used, and the last one could be kept. Suffering from success, folks. |
Sure
I don't think removing devtools features is a good idea. It could be possible for this addon to use middle click without completely breaking that feature because dragging and clicking are different actions (in theory). On that topic, if this addon can be bound to middle mouse, then surely block-cherry-picking should be able to too. Maybe these addons can get merged together into a "Better dragging" addon and have a bunch of settings for "middle mouse", "control+click", etc. so people can configure it however they want |
|
Or a new "keybind" setting type 👀
…________________________________
From: GarboMuffin ***@***.***>
Sent: Sunday, September 26, 2021 7:51:16 PM
To: ScratchAddons/ScratchAddons ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [ScratchAddons/ScratchAddons] New addon: Shift+click drag to duplicate block (#3541)
Should this addon also have a "flip controls" setting, similar to "grab single block with Ctrl key"?
Sure
we might actually want to use Alt instead of Shift
What's the proposed replacement for the alt+click devtools shortcuts? Currently those shortcuts are the easiest or only way use those features on some systems.
We could also consider having this new addon duplicate blocks when being dragged with mouse middle click. But we'd need to remove the "middle click to go to custom block definition" feature of devtools.
I don't think removing devtools features is a good idea. It could be possible for this addon to use middle click without completely breaking that feature because dragging and clicking are different actions.
On that topic, if this addon can be bound to middle mouse, then surely block-cherry-picking should be able to too. Maybe these addons can get merged together into a "Better dragging" addon and have a bunch of settings for "middle mouse", "control+click", etc. so people can configure it however they want
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#3541 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOT5DEWDCUO4BRTYKH544GDUD65YJANCNFSM5EP5KJZQ>.
|
|
If we want to keep middle-click/alt-click, we could change all of the Devtools usages to only occur when the keybind is released in order to differentiate between a click and a drag. |
|
On a separate note, it would probably be a good idea to provide an API to handle keybinds and key presses. What if someone has missing/dead keys on their keyboard or has disabilities that make it harder to or prevent them from using certain key combinations? It would make sense to have a "Scratch Addons keybinds" section in the settings page, or even somewhere in the editor. This would also serve as a nice reminder that certain features are enabled by Scratch Addons. |
I like this idea. Devtools could wait until Alt+Click is released (keyup), so both addons could use the Alt hotkey at the same time. |
|
It will be looked into |
|
Thanks! |
Or maybe set a global variable in keyup-using devtools versions and don't run this addon if the devtools elements are still present without the variable being set. |
|
I still don't understand why we continue to update the Devtools extension. It seems to be doing more harm than good. |
I don't think whether we update it would change the user count. It has looked pretty much the same yet it still grew. If we update it, at least we can make it compatible with other addons. |
|
Griffpatch is unsure about having Alt+Click and Alt+drag use the same key. I suggested and he agreed:
The only real pain is number 1, and we could hint users that it changed to Shift if devtools sees them Alt+Clicking blocks without dragging them. The final list of all addons and hotkeys would be:
Edit: devtools also owns Ctrl+Space in the workspace, where it is equivalent to Alt+Click and mouse middle click. Ugh... |
I'll be releasing a new version of DevtoolsExtension in the next few days, to avoid any problems, since theoretically a user could run an old DevtoolsExtension version that listens to Alt+Click at the same time as this new addon. |
Alt+click is already used by editor-devtools, so that can't be used hereAlt+ctrl+drag (cmd+option+drag on macOS) will duplicate only the current block, like block-cherry-picking