Combine bugfixes into one addon - #2568
Closed
lisa-wolfgang wants to merge 4 commits into
Closed
Conversation
Contributor
|
This needed more discussion...
…________________________________
From: lisa-wolfgang ***@***.***>
Sent: Saturday, May 22, 2021 9:41:10 PM
To: ScratchAddons/ScratchAddons ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [ScratchAddons/ScratchAddons] Combine bugfixes into one addon (#2568)
Resolves #2562<#2562>
Changes
"Fix broken SVG uploads" and "Do not automatically run duplicated blocks" have been combined into "Fix Scratch bugs". This new addon is recommended and enabled by default.
Reason for changes
Because Maximouse said so To have all bugfixes in one convenient location and to make it easier to add new bugfixes in the future
Tests
Both of the imported addons seem to still work properly.
________________________________
You can view, comment on, or merge this pull request online at:
#2568
Commit Summary
* Combine bugfixes into one addon
* Format code
File Changes
* M addons/addons.json<https://github.com/ScratchAddons/ScratchAddons/pull/2568/files#diff-bb33cb076f6d0e3d6cfe187036954a1ca81e6bf0b7f141f578f4805426fa48e7> (3)
* A addons/bugfixes/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/2568/files#diff-977f4620158ce9ff87f78af4fd5d8bdc5d79d9e87e8befbfbc85a4b7b163d6fd> (45)
* R addons/bugfixes/fix-pasted-scripts.js<https://github.com/ScratchAddons/ScratchAddons/pull/2568/files#diff-4e9863a2297bb82466fb97217645dd9a55760eb353b4293bb07791a1f893b734> (11)
* R addons/bugfixes/fix-uploaded-svgs.js<https://github.com/ScratchAddons/ScratchAddons/pull/2568/files#diff-62af5d42768d074725cef78e18fa3038958cd6a1ee9e33a092025261600e719b> (2)
* D addons/fix-pasted-scripts/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/2568/files#diff-6c2892cd9ff7dadf85d3ff064eeab9614019a5670ad15bff792c5e372f37443a> (30)
* D addons/fix-uploaded-svgs/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/2568/files#diff-3893773c1feab20eddc19935f6b0df645ac6705a5fffddf2c5d43d516551aa67> (15)
Patch Links:
* https://github.com/ScratchAddons/ScratchAddons/pull/2568.patch
* https://github.com/ScratchAddons/ScratchAddons/pull/2568.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#2568>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOT5DEVGXSGOCD7JFDWXKC3TPB2NNANCNFSM45LISFJA>.
|
Member
Author
|
We can continue to discuss here. |
Member
|
Maybe for v1.16.0 |
Member
Author
|
I just added a fix for comment dragging that worked when I made it, but it doesn't appear to work now because my computer is sluggish and needs to be restarted. It could be that the addon is loading faster than the |
Member
|
I'm closing this for now I guess. IMO they should be separate addons until we add a way to have a help modal in individual settings, otherwise we can't provide enough context to the user on what's being fixed (this would remove all mentions to Affinity Designer) |
Member
Author
|
Perhaps a new tag for bugfix addons would be better? |
Contributor
@lisa-wolfgang Yes, definitely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2562
Changes
"Fix broken SVG uploads" and "Do not automatically run duplicated blocks" have been combined into "Fix Scratch bugs". This new addon is recommended and enabled by default.
Reason for changes
Because Maximouse said soTo have all bugfixes in one convenient location and to make it easier to add new bugfixes in the futureTests
Both of the imported addons seem to still work properly.
Some considerations