Skip to content

Adding a check-manifest GHA and updating dependent files#57

Merged
bjlittle merged 5 commits into
SciTools:masterfrom
HGWright:mfest_gha
Mar 30, 2023
Merged

Adding a check-manifest GHA and updating dependent files#57
bjlittle merged 5 commits into
SciTools:masterfrom
HGWright:mfest_gha

Conversation

@HGWright

@HGWright HGWright commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Added a check-manifest GHA and updated the MANIFEST.in file and the pyproject.toml to match it.

closes #58 & #59

@HGWright HGWright linked an issue Mar 15, 2023 that may be closed by this pull request
@HGWright HGWright requested a review from bjlittle March 15, 2023 16:56

@bjlittle bjlittle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright This is great, thanks for tidying this up 👍

However, I've got one suggestion up for discussion...

Comment thread MANIFEST.in
Comment thread MANIFEST.in Outdated
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>

@bjlittle bjlittle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright Nice one, this looks good to me 😄

@bjlittle bjlittle merged commit a7427c6 into SciTools:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update MANIFEST.in Add GHA MANIFEST checking

2 participants