Skip to content

Move to python 3.12#271

Merged
trexfeathers merged 8 commits into
SciTools:mainfrom
HGWright:python-3.12
Nov 7, 2024
Merged

Move to python 3.12#271
trexfeathers merged 8 commits into
SciTools:mainfrom
HGWright:python-3.12

Conversation

@HGWright

Copy link
Copy Markdown
Contributor

🚀 Pull Request

Description


Comment thread .github/workflows/ci-wheels.yml Outdated
Comment thread requirements/py312.yml
@HGWright

HGWright commented Sep 27, 2024

Copy link
Copy Markdown
Contributor Author

@trexfeathers Two things about this:

  1. Im a bit confused why this check is expected (could it be a handover of when that did run in this PR) but i still don't expect this.
  2. Had to do force push for conflicts, I think because this used to have a file that did not exist locally (py39 lockfile).

@trexfeathers

trexfeathers commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

GitHub auto-merge must have 'required checks' in the branch protection rules. It looks like you (or maybe @bjlittle?) selected the following to be required (minus the CLA, which I selected):

This might mean we want to adjust our testing naming somehow so this doesn't become a problem every time we switch Python versions?

image

@trexfeathers trexfeathers merged commit a85ef50 into SciTools:main Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants