fix: model does not stop on stop_training == true #1170#1171
Merged
Oceania2018 merged 1 commit intoSciSharp:masterfrom Sep 13, 2023
Merged
fix: model does not stop on stop_training == true #1170#1171Oceania2018 merged 1 commit intoSciSharp:masterfrom
Oceania2018 merged 1 commit intoSciSharp:masterfrom
Conversation
asaf92
changed the title
Contributor
|
LGTM @Oceania2018 |
Contributor
Author
|
Hey @Wanglongzhi2001, thank you for accepting my PR! |
Member
|
Released v0.110.3. Can you check if this version works? |
Contributor
It seems to work if "Tensorflow.Keras.dll" is directly generated from the current version of the repository. But not from the released v0.110.3. |
Contributor
Author
|
@Oceania2018 I decompiled with JetBrains and the changes are not included in the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not test it, but debugging showed that this is the code that is missing.
stop_trainingis only updated but never used.This solves #1170