feat: add rnn basic modules#1097
Merged
SanftMonster merged 3 commits intoSciSharp:rnn-devfrom Jun 7, 2023
Merged
Conversation
Contributor
|
Quite not sure, but I think that by adding some class or interface, Nest can hold less. By exemple what is done with the NestType may, prehaps, done by splitting or generic type handling. I seen that "NestType.Node" can't use PackSequenceInternal(). Change class architecture can prehaps avoid possibility to call PackSequenceInternal() from a Nest that should currently have NestType.Node. I hope to don't borring you to many, I will help you if you want. After that, you've done a lot of work :) ! Ho ! Before I forgot ! Well handling for Tensors to Tensor. it's verry helpfull for debuging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tensorsto make it support nested structure.Nest<T>andINestStructure<T>to enable better use of nest structures.TensorArray.Note:
The
ILayer.Callneeds to be fully refactored in the future.@DevNullx64 This PR partially refactors the
Tensors, which is mentioned in #1088 . Please feel free to comment anything about that :). Since the target branch is a dev branch, this PR will be merged at once. But if there's disadvantages you catch, we could improve it before merging to master branch.In this PR the implicit conversion from
TensorstoTensoris still kept because the main purpose of this PR is to support RNN. However I add a check when doing this implicit conversion. If aTensorshas more than oneTensor, then an exception will be thrown. In this way, some error will be visiable.