Conversation
IModel.Dictionary<string, float> evaluate(NDArray, NDArray, ...) is now IModel.Dictionary<string, float> evaluate(Tensor, Tensor, ...) Merge Model.Evaluate.test_step_multi_inputs_function(...) and Model.Evaluate.test_function(...) Note: An internal function need to add an explicit cast in Tensor
|
LGTM,Model.Evaluate does have some repetitive code. For example, test_function and test_step_multi_inputs_function are actually doing the same thing, this modification can reduce the repetitive code of overloading. |
|
BTW, in the test_step_multi_inputs_function of Model.Evaluate, should train_step be changed to test_step,? can you help change it? |
|
Thank ! |
Fix my bad: Bad handling between test_function and test_step_multi_inputs_function.
|
thank @AsakusaRinne to had change pull request title. I will try to take care next. |
|
Looks good to me. |
|
@DevNullx64 , Seems there exists some bug in the model.evaluate, If the input data is NDArray type, it will matchs both evaluate(Tensor,..) and evaluate(IEnumable,... signatures, which will result in an ambiguous error in the call model.evaluate. The following is a example: |
No description provided.