Skip to content

Add shape deduce for mean square error grad.#1010

Merged
Oceania2018 merged 1 commit intoSciSharp:masterfrom
SanftMonster:fix_mean_square_error_grad
Mar 24, 2023
Merged

Add shape deduce for mean square error grad.#1010
Oceania2018 merged 1 commit intoSciSharp:masterfrom
SanftMonster:fix_mean_square_error_grad

Conversation

@SanftMonster
Copy link
Collaborator

The current implementation of mean square error grad will cause problem when the inputs are not fully specified. For example, the following code will throw an exception on master branch. This PR fixes it.

var model = keras.Sequential(new List<ILayer>()
            {
                keras.layers.InputLayer(5),
                keras.layers.Dense(1)
            });
var x = tf.ones((3, 5));
var y = tf.zeros(3);
using (var tape = tf.GradientTape())
{
    var y_pred = model.Apply(x);
    var loss = keras.losses.MeanSquaredError().Call(y, y_pred);
    var gradient = tape.gradient(loss, model.TrainableWeights);
    foreach (var g in gradient)
    {
        Console.WriteLine(g);
    }
}

@SanftMonster SanftMonster added the bug Something isn't working label Mar 23, 2023
@Oceania2018 Oceania2018 merged commit 86eb48b into SciSharp:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants