The log levels defined on llama.cpp and LlamaSharp side were not aligned anymore (issue #995)#997
Conversation
…ned anymore (issue SciSharp#995)
|
It looks like the idea of The best way I can think of to handle this is to have a threadstatic field which stores the last log level used. I'll add a comment inline to show what I mean. |
| Continue = 5, | ||
| } | ||
|
|
||
| internal static class LLamaLogLevelExtensions |
There was a problem hiding this comment.
| internal static class LLamaLogLevelExtensions | |
| internal static class LLamaLogLevelExtensions | |
| { | |
| [ThreadStatic] private static LogLevel _previous; | |
| public static LogLevel ToLogLevel(this LLamaLogLevel llama) | |
| { | |
| _previous = (llama) switch | |
| { | |
| LLamaLogLevel.None => LogLevel.None, | |
| LLamaLogLevel.Debug => LogLevel.Debug, | |
| LLamaLogLevel.Info => LogLevel.Information, | |
| LLamaLogLevel.Warning => LogLevel.Warning, | |
| LLamaLogLevel.Error => LogLevel.Error, | |
| LLamaLogLevel.Continue => _previous, | |
| _ => throw new ArgumentOutOfRangeException(nameof(llama), llama, null) | |
| }; | |
| return _previous; | |
| } |
There was a problem hiding this comment.
(Note that I haven't tested this, but hopefully it illustrates what I mean)
|
Looks good to me, thanks for fixing this! Just waiting for the tests to run and then I'll merge it :) |
|
Hum I don't get the CI error running locally |
|
I'll re-run it, unfortunately our CI is flakey sometimes |
|
Looks like it worked this time. |
2 participants
Following this issue #995
After this PR on the llama.cpp repo the loglevel defined on both llama.cpp and LlamaSharp sides were not aligned anymore. This misalignment made the model weight loading fail when a custom logger is used.
Help
I am just wondering if it is correct to consider the
CONTlog level as equivalent toNONE.