Non-deterministic default seed (+minor sampling parameters names & comments update)#993
Merged
martindevans merged 4 commits intoSciSharp:masterfrom Nov 24, 2024
Merged
Conversation
Lyrcaxis
force-pushed
the
distribution-seed-fix
branch
from
193ee52 to
b943d1d
Compare
martindevans
requested changes
Nov 24, 2024
Member
martindevans
left a comment
martindevans
left a comment
There was a problem hiding this comment.
Looks good, just a couple of minor nits :)
martindevans
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distribution seed for sampling used to always be fixed (42) by default, causing deterministic sampling.
This PR switches it to be randomly initialized with each new sampling pipeline instance.
Also changed some of the sampling pipeline's members' names and comments to better reflect their purpose.
AlphaFrequency-->FrequencyPenaltyAlphaPresence-->PresencePenaltyPenalizeEOS-->PreventEOSPenalizeEOSactually completely takes away the possibility forEOS_TOKENto be sampled, causing infinite generation.