Skip to content

fix: list-remote --filter --latest panics when filter has no results - #1184

Merged
Schniz merged 5 commits into
Schniz:masterfrom
julescubtree:handle-latest-when-no-versions-found
Oct 6, 2024
Merged

Schniz merged 5 commits into
Schniz:masterfrom
julescubtree:handle-latest-when-no-versions-found

Conversation

@julescubtree

Copy link
Copy Markdown
Contributor

This PR checks for results before modifying the all_versions vector, and opts for .swap() and .truncate() over .drain() to reduce overhead and improve efficiency.

@changeset-bot

changeset-bot Bot commented Jun 22, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6630bf1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 22, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 6:13am

@Schniz Schniz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you
i'll add a test :)

This branch was successfully deployed

1 active deployment
Preview — 6630bf1a Deployed Oct 6, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants