Skip to content

Support XDG convention in MacOS too - #1143

Merged
kodiakhq[bot] merged 5 commits into
masterfrom
allow-xdg-in-macos
May 29, 2024
Merged

kodiakhq[bot] merged 5 commits into
masterfrom
allow-xdg-in-macos

Conversation

@Schniz

@Schniz Schniz commented May 29, 2024 •

Copy link
Copy Markdown
Owner

This PR resolves #959 as it is based on it and I'm pushing more code to make it compatible with the changes done while it wasn't merged.

Thank you @utkarshgupta137 for the initial work 🙏

@Schniz Schniz self-assigned this May 29, 2024
@vercel

vercel Bot commented May 29, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 2:55pm

@changeset-bot

changeset-bot Bot commented May 29, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759b0fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@utkarshgupta137

Copy link
Copy Markdown
Contributor

Looks good to me, although I'm no longer using Node.js or fnm, so I won't be able to test this.

@Schniz
Schniz marked this pull request as ready for review May 29, 2024 14:58
@kodiakhq
kodiakhq Bot merged commit f76a001 into master May 29, 2024
@kodiakhq
kodiakhq Bot deleted the allow-xdg-in-macos branch May 29, 2024 16:04
@github-actions github-actions Bot mentioned this pull request May 29, 2024

This branch was successfully deployed

1 active deployment
Preview — 759b0fe4 Deployed May 29, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants