Skip to content

fix: support x64-musl - #1109

Merged
Schniz merged 3 commits into
Schniz:masterfrom
Vinfall:musl-support
May 24, 2024
Merged

Schniz merged 3 commits into
Schniz:masterfrom
Vinfall:musl-support

Conversation

@Vinfall

@Vinfall Vinfall commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

Yes, an easy fix as silly as bypassing the hardcoded check and then set FNM_NODE_DIST_MIRROR & FNM_ARCH in shell rc.

Yes, an easy fix as silly as bypassing the hardcoded check and then set `FNM_NODE_DIST_MIRROR` & `FNM_ARCH` in shell rc.
@changeset-bot

changeset-bot Bot commented Apr 11, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ba7008e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Apr 11, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:24am

@Vinfall

Vinfall commented Apr 11, 2024 •

Copy link
Copy Markdown
Contributor Author

I think it's also possible to support other musl architectures, if the unofficial node mirror has builds for those. But I'm lazy enough to pretend they do not exist. nvm, unofficial node mirror only has x64-musl tarballs.

@Schniz
Schniz merged commit 8f3acbb into Schniz:master May 24, 2024
@github-actions github-actions Bot mentioned this pull request May 24, 2024
@Vinfall
Vinfall deleted the musl-support branch May 25, 2024 01:26

This branch was successfully deployed

1 active deployment
Preview — ba7008e8 Deployed May 24, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants