Conversation
…eative/docker-python-base into feature/implement-poetry
hillairet
left a comment
hillairet
left a comment
There was a problem hiding this comment.
@rahulpatidar0191 I made changes to the code directly because it was faster than putting them in a Request for changes here.
Please have a look and more importantly test the changes since I didn't.
Exciting change to this repo!
tests/Dockerfile
Outdated
| FROM $IMAGE_VERSION | ||
|
|
||
| # Copy the files for the server | ||
| COPY --from=requirements-stage /tmp/requirements.txt /app/requirements.txt |
There was a problem hiding this comment.
Change the directory here to match the above
tests/Dockerfile
Outdated
|
|
||
| # Copy the files for the server | ||
| COPY --from=requirements-stage /tmp/requirements.txt /app/requirements.txt | ||
|
|
There was a problem hiding this comment.
Added install requirements
hillairet
left a comment
hillairet
left a comment
There was a problem hiding this comment.
Actually let's not use our python base for the requirements-stage but instead the python base image, then output in /tmp/requirements.txt cause our base docker image is not needed.
@hillairet I am not sure I follow, you want to move requirements stage from /root/test/Dockerfile -> /root/Dockerfile? |
|
@hillairet Did you mean to approve this? |
hillairet
left a comment
hillairet
left a comment
There was a problem hiding this comment.
right I approved the wrong PR it seems! 😅
…ocker-python-base into feature/implement-poetry
|
Haha yeah. Please clarify your previous comment as well |
hillairet
left a comment
hillairet
left a comment
There was a problem hiding this comment.
I implemented what I meant to say. Not tested though.
|
Thanks, I tested it out and it works 🎉 |
2 participants
Changed pyproject.toml to use poetry
Closes: #346
Closes : #347
There's an issue with Docstring which I have created an issue for here
Not sure why github actions still passed
I was also hoping to find a way where I can pass the Docker Image version here using the github action by build-args like you do here but haven't been able to figure it out. So it needs to be manually updated in the Dockerfile of webapps before a tag is released