Skip to content

chore: Wrap membership event reasons in parentheses #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 2 commits into from
Jul 30, 2026
Merged

chore: Wrap membership event reasons in parentheses #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d808234
chore: Wrap membership event reason in parentheses
Steffo99 Jul 28, 2026
02f9f94
fix: also add leave reasons
7w1 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wrap_membership_event_reasons_in_parentheses.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

# Wrap membership event reasons in parentheses
55 changes: 21 additions & 34 deletions src/app/hooks/useMemberEventParser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,8 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
<DecoratedUser roomId={roomId ?? ''} userId={senderId} userName={senderName} />
<Text>{' accepted '}</Text>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>
{`'s join request `}
{reason}
</Text>
<Text>{`'s join request`}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -102,7 +100,7 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
<DecoratedUser roomId={roomId ?? ''} userId={senderId} userName={senderName} />
<Text>{' invited '}</Text>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>{reason}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -114,10 +112,8 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
body: (
<>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>
{' requested to join room: '}
<i>{reason}</i>
</Text>
<Text>{' requested to join room'}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -130,6 +126,7 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
<>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>{' joined the room'}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -143,20 +140,16 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
senderId === userId ? (
<>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>
{' rejected the invitation '}
{reason}
</Text>
<Text>{' rejected the invitation'}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
) : (
<>
<DecoratedUser roomId={roomId ?? ''} userId={senderId} userName={senderName} />
<Text>{' rejected '}</Text>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>
{`'s join request `}
{reason}
</Text>
<Text>{`'s join request`}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -169,20 +162,16 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
senderId === userId ? (
<>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>
{' revoked joined request '}
{reason}
</Text>
<Text>{' revoked joined request'}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
) : (
<>
<DecoratedUser roomId={roomId ?? ''} userId={senderId} userName={senderName} />
{' revoked '}
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>
{`'s invite `}
{reason}
</Text>
<Text>{`'s invite`}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -196,7 +185,7 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
<DecoratedUser roomId={roomId ?? ''} userId={senderId} userName={senderName} />
<Text>{' unbanned '}</Text>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>{reason}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -208,17 +197,15 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
senderId === userId ? (
<>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>
{' left the room '}
{reason}
</Text>
<Text>{' left the room '}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
) : (
<>
<DecoratedUser roomId={roomId ?? ''} userId={senderId} userName={senderName} />
<Text>{' kicked '}</Text>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>{reason}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -232,7 +219,7 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
<DecoratedUser roomId={roomId ?? ''} userId={senderId} userName={senderName} />
<Text>{' banned '}</Text>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>{reason}</Text>
<Text>{reason ? `(${reason})` : null}</Text>
</>
),
};
Expand All @@ -257,7 +244,7 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
) : (
<>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={prevUserName} />
<Text>{' removed their display name '}</Text>
<Text>{' removed their display name'}</Text>
</>
),
};
Expand All @@ -274,7 +261,7 @@ const parseMemberEvent: MemberEventParser = (mEvent) => {
) : (
<>
<DecoratedUser roomId={roomId ?? ''} userId={userId} userName={userName} />
<Text>{' removed their avatar '}</Text>
<Text>{' removed their avatar'}</Text>
</>
),
};
Expand Down
Loading