Skip to content

Improved macOS support: java.nio.file Watch Service #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sungshik merged 18 commits into from
Apr 30, 2025

Add helper inner class to group thread-safety-critical code together …

5b04d16
Select commit
Loading
Failed to load commit list.
Merged

Improved macOS support: java.nio.file Watch Service #41

Add helper inner class to group thread-safety-critical code together …
5b04d16
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 30, 2025 in 0s

80.6% (+15.2%) compared to 73b0238

View this Pull Request on Codecov

80.6% (+15.2%) compared to 73b0238

Details

Codecov Report

Attention: Patch coverage is 70.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 80.6%. Comparing base (73b0238) to head (5b04d16).

Files with missing lines Patch % Lines
...a/engineering/swat/watch/impl/mac/MacWatchKey.java 80.6% 4 Missing and 8 partials ⚠️
.../engineering/swat/watch/impl/mac/MacWatchable.java 56.5% 8 Missing and 2 partials ⚠️
...ava/engineering/swat/watch/impl/jdk/JDKPoller.java 63.6% 6 Missing and 2 partials ⚠️
...gineering/swat/watch/impl/mac/MacWatchService.java 53.8% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                       Coverage Diff                        @@
##             improved-macos-support-main     #41      +/-   ##
================================================================
+ Coverage                           65.3%   80.6%   +15.2%     
- Complexity                           136     163      +27     
================================================================
  Files                                 20      23       +3     
  Lines                                705     822     +117     
  Branches                              80      95      +15     
================================================================
+ Hits                                 461     663     +202     
+ Misses                               205      97     -108     
- Partials                              39      62      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov