Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
+ Coverage 80.8% 81.6% +0.8%
- Complexity 135 163 +28
=========================================
Files 16 23 +7
Lines 568 827 +259
Branches 66 97 +31
=========================================
+ Hits 459 675 +216
- Misses 69 91 +22
- Partials 40 61 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…h Queue; File System Events)
…n FS event stream using the native macOS APIs
…sing the native APIs to the caller
…at fully implements the `java.nio.file.WatchService` interface
…/nio-file-watch-service
Improved macOS support: JNA
…t/nio-file-watch-service
…io-file-watch-service Improved macOS support: `java.nio.file` Watch Service
DavyLandman
reviewed
Apr 30, 2025
DavyLandman
reviewed
Apr 30, 2025
DavyLandman
reviewed
Apr 30, 2025
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
Just a few things I noticed.
…-support/file-moves
…mall-fixes Improved macOS support: Small fixes
…ile-moves Improved macOS support: Support for moving/renaming files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is the main PR to address #4. Helper PRs:
java.nio.fileWatch Service #41Tasks
ITEM_RENAMEDflag), including tests (useFiles.move)Enqueue collections of events instead of individual events inMoved: Enqueue collections of events instead of individual events inWatchKeyMacWatchKey? #48Use an internal index to more accurately track renamesMoved: Use an internal index to more accurately track renames on macOS #49